[
https://issues.apache.org/jira/browse/HADOOP-16395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875415#comment-16875415
]
yanghuafeng commented on HADOOP-16395:
--------------------------------------
hi, [~xkrogen]
Actually, the AutoCloseable will be used in try(){} clause in most case. So
from my opinion, it is also not suitable.
{quote} it seems odd to close something and then continue to use it. Is it
possible for us to close it later, or will it mess up the proxy to instantiate
the new one first{quote}
Yes, the namespace about FCQ is the key of MetricsProxy HashMap. If we refresh
call queue between the same namespace, FCQ will use older one instead of
creating new one proxy. In this case, we will miss the metrics proxy after
closing FCQ.
> when CallQueueManager swap queues, we should remove metrics about FCQ
> ---------------------------------------------------------------------
>
> Key: HADOOP-16395
> URL: https://issues.apache.org/jira/browse/HADOOP-16395
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common, ipc
> Affects Versions: 3.2.0
> Reporter: yanghuafeng
> Priority: Minor
> Attachments: HADOOP-16395.001.patch, HADOOP-16395.002.patch
>
>
> when we use "dfsadmin -refreshCallQueue" between FCQ and LBQ, we find that
> the metrics about FCQ still display by the JMX. Normally the metrics should
> disappear like what DecayRpcScheduler did.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
