swagle commented on a change in pull request #1055: HDDS-1705. Recon: Add
estimatedTotalCount to the response of ...
URL: https://github.com/apache/hadoop/pull/1055#discussion_r300185879
##########
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServer.java
##########
@@ -63,6 +70,8 @@ public Void call() throws Exception {
OzoneConfiguration ozoneConfiguration = createOzoneConfiguration();
OzoneConfigurationProvider.setConfiguration(ozoneConfiguration);
+ JooqConfigurationProvider.setConfiguration(sqlConfiguration);
Review comment:
This is an anti-pattern that leads to un-clean code. The only reason to do
this for OzoneConfiguration is because of mixing non DI code with DI. Since the
member itself is provided by the injector, the JooqConfiguration could just be
provided explicitly by a module like ReconController or the one created by the
Sql test classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
