swagle commented on a change in pull request #1055: HDDS-1705. Recon: Add
estimatedTotalCount to the response of ...
URL: https://github.com/apache/hadoop/pull/1055#discussion_r300188458
##########
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerKeyMapperTask.java
##########
@@ -144,24 +150,35 @@ private void deleteOMKeyFromContainerDB(String key)
Table.KeyValue<ContainerKeyPrefix, Integer>> containerIterator =
containerDBServiceProvider.getContainerTableIterator();
- Set<ContainerKeyPrefix> keysToDeDeleted = new HashSet<>();
+ Set<ContainerKeyPrefix> keysToBeDeleted = new HashSet<>();
while (containerIterator.hasNext()) {
Table.KeyValue<ContainerKeyPrefix, Integer> keyValue =
containerIterator.next();
String keyPrefix = keyValue.getKey().getKeyPrefix();
if (keyPrefix.equals(key)) {
- keysToDeDeleted.add(keyValue.getKey());
+ keysToBeDeleted.add(keyValue.getKey());
}
}
- for (ContainerKeyPrefix containerKeyPrefix : keysToDeDeleted) {
+ for (ContainerKeyPrefix containerKeyPrefix : keysToBeDeleted) {
containerDBServiceProvider.deleteContainerMapping(containerKeyPrefix);
+
+ // decrement count and update containerKeyCount.
+ Long containerID = containerKeyPrefix.getContainerId();
+ long keyCount =
+ containerDBServiceProvider.getKeyCountForContainer(containerID);
+ if (keyCount > 0) {
+ containerDBServiceProvider.storeContainerKeyCount(containerID,
Review comment:
Is this to keep counts up to date? Seems this change is not needed for this
test, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
