mukul1987 commented on a change in pull request #1051: HDDS-1748. Error message
for 3 way commit failure is not verbose. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1051#discussion_r300929755
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientRatis.java
##########
@@ -258,8 +258,15 @@ public XceiverClientReply watchForCommit(long index, long
timeout)
.sendWatchAsync(index, RaftProtos.ReplicationLevel.ALL_COMMITTED);
replyFuture.get(timeout, TimeUnit.MILLISECONDS);
} catch (Exception e) {
+ String nodes = " with Datanodes : ";
Throwable t = HddsClientUtils.checkForException(e);
- LOG.warn("3 way commit failed ", e);
+ for (DatanodeDetails datanodeDetails : pipeline.getNodes()) {
+ nodes += datanodeDetails.getHostName() + "["
Review comment:
This line will thrown findbugs, lets use StringBuilder here in place of
concatenation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
