steveloughran commented on a change in pull request #974: HDFS-9913.DispCp
doesn't use Trash with -delete option
URL: https://github.com/apache/hadoop/pull/974#discussion_r302509319
##########
File path:
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpOptions.java
##########
@@ -225,6 +225,45 @@ public void testSetDeleteMissing() {
}
}
+ @Test
+ public void testDeleteMissingUseTrash() {
Review comment:
All assert true/false calls *MUST* have a string message to include on a
failure.
Imagine you've got a report of a test run failure on jenkins, you want to
understand what has failed without trying to work out exactly which line does
what on that specific branch of the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
