steveloughran commented on a change in pull request #974: HDFS-9913.DispCp
doesn't use Trash with -delete option
URL: https://github.com/apache/hadoop/pull/974#discussion_r302511667
##########
File path:
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyCommitter.java
##########
@@ -515,6 +518,17 @@ private void deleteMissing(Configuration conf) throws
IOException {
formatDuration(deletionEnd - listingStart));
}
+ private boolean deletePath(FileSystem targetFS, Path targetEntry,
+ Configuration conf) throws IOException {
+ if(conf.getBoolean(DistCpConstants.CONF_LABEL_DELETE_MISSING_USETRASH,
Review comment:
nit: add whitespace after `if`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]