[
https://issues.apache.org/jira/browse/HADOOP-7445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079313#comment-13079313
]
Tsz Wo (Nicholas), SZE commented on HADOOP-7445:
------------------------------------------------
Todd, nice works. Some comments:
- It is better to simply use org_apache_hadoop_util_NativeCrc32_CHECKSUM_CRC32
and org_apache_hadoop_util_NativeCrc32_CHECKSUM_CRC32C, instead of defining two
more constants, CRC32_ZLIB_POLYNOMIAL and CRC32C_POLYNOMIAL.
- How about moving everything in gcc_optimizations.h to org_apache_hadoop.h?
> Implement bulk checksum verification using efficient native code
> ----------------------------------------------------------------
>
> Key: HADOOP-7445
> URL: https://issues.apache.org/jira/browse/HADOOP-7445
> Project: Hadoop Common
> Issue Type: Improvement
> Components: native, util
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-7445.txt, hadoop-7445.txt, hadoop-7445.txt,
> hadoop-7445.txt, hadoop-7445.txt
>
>
> Once HADOOP-7444 is implemented ("bulk" API for checksums), good performance
> gains can be had by implementing bulk checksum operations using JNI. This
> JIRA is to add checksum support to the native libraries. Of course if native
> libs are not available, it will still fall back to the pure-Java
> implementations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
