[ 
https://issues.apache.org/jira/browse/HADOOP-7445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079440#comment-13079440
 ] 

Todd Lipcon commented on HADOOP-7445:
-------------------------------------

Hi Nicholas. Thanks for reviewing.

- The reason I opted to use a second set of constants was because Kihwal had 
asked me to split the code into two distinct parts: one that does the JNI 
wrapping, and one that is a straight C library. Since the org_apache_hadoop_* 
constants are generated by javah, they aren't usable from the C library 
portion. Does that make sense?

- Same goes for gcc_optimizations.h -- since org_apace_hadoop.h has 
JNI-specific stuff, I didn't want to include it from within bulk_crc32.c, the 
"non-JNI" section of the code.

Does that make sense?

> Implement bulk checksum verification using efficient native code
> ----------------------------------------------------------------
>
>                 Key: HADOOP-7445
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7445
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: native, util
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7445.txt, hadoop-7445.txt, hadoop-7445.txt, 
> hadoop-7445.txt, hadoop-7445.txt
>
>
> Once HADOOP-7444 is implemented ("bulk" API for checksums), good performance 
> gains can be had by implementing bulk checksum operations using JNI. This 
> JIRA is to add checksum support to the native libraries. Of course if native 
> libs are not available, it will still fall back to the pure-Java 
> implementations.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to