[
https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo (Nicholas), SZE updated HADOOP-7524:
-------------------------------------------
Component/s: ipc
- Change RPC.Server.addProtocol(..) as below.
{code}
public abstract <PROTO extends VersionedProtocol, IMPL extends PROTO>
Server addProtocol(Class<PROTO> protocolClass, IMPL protocolImpl
) throws IOException;
{code}
- In WritableRpcEngine.getSuperInterfaces(..),
-* check if each class is a subclass of VersionedProtocol before adding it to
the list.
-* Change it to private.
- Add final to WritableRpcEngine.writableRpcVersion.
- Use junit4 Assert in TestMulitpleProtocolServer (i.e. org.junit.Assert
instead of junit.framework.Assert)
- Rename protocolImplSet to protocolImplMap since it is a Map.
- Remove the first "this.declaringClassProtocolName = ..." below.
{code}
@@ -87,7 +121,9 @@
}
this.clientMethodsHash = ProtocolSignature.getFingerprint(method
.getDeclaringClass().getMethods());
+ this.declaringClassProtocolName =
RPC.getProtocolName(method.getDeclaringClass());
}
+ this.declaringClassProtocolName =
RPC.getProtocolName(method.getDeclaringClass());
}
{code}
- There are two findbugs warnings in ProtoNameVer.equals(..); see [the attached
report|https://issues.apache.org/jira/secure/attachment/12489657/newPatchFindbugsWarnings.html].
- VerProtocolImpl.getSupportedProtocolVersions(..) is unused.
- Revert the (write space) change in AvroRpcEngine.
> Change RPC to allow multiple protocols including multuple versions of the
> same protocol
> ---------------------------------------------------------------------------------------
>
> Key: HADOOP-7524
> URL: https://issues.apache.org/jira/browse/HADOOP-7524
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: newPatchFindbugsWarnings.html, rpc2.patch,
> rpc2_trunk.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
