[
https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081250#comment-13081250
]
Todd Lipcon commented on HADOOP-7524:
-------------------------------------
- the word Multiple is misspelled in {{TestMulitpleProtocolServer}}
- Perhaps rename {{ProtocolAnnotation}} to {{RPCProtocolName}} or maybe
{{ProtocolInfo}} to be more consistent with the other annotations we use here
(like KerberosInfo and TokenInfo)
- Some typos in the javadoc of {{ProtocolAnnotation}}:
-- "The protocol name is *used to when* a client..."
-- "*Bt* default the clss"
-- Missing '.' at end of first paragraph
- {{String protocolName()}} should be indented in the body of this annotation
class
- In the test case, maybe the different methods should return strings - eg:
{code}
String ping() {
return "V1 implementation";
}
{code}
so that you can assert that the correct implementation has been delegated to?
- typo in method name: {{getProtocolIntefaces}}
- use javadoc style comments for the descriptions of ProtoNameVer,
ProtoClassProtoImpl, etc.
- missing indentation where RPC.VersionMismatch is thrown
- typo in javadoc: "the impl of the protocol - *is is* called"
> Change RPC to allow multiple protocols including multuple versions of the
> same protocol
> ---------------------------------------------------------------------------------------
>
> Key: HADOOP-7524
> URL: https://issues.apache.org/jira/browse/HADOOP-7524
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: newPatchFindbugsWarnings.html, rpc2.patch,
> rpc2_trunk.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
