xiaoyuyao commented on a change in pull request #1257: HDDS-1913. Fix
OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312674369
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -388,7 +388,9 @@ public void deleteVolume(String volumeName) throws
IOException {
@Override
public void createBucket(String volumeName, String bucketName)
throws IOException {
- createBucket(volumeName, bucketName, BucketArgs.newBuilder().build());
+ // Set acls of current user.
+ createBucket(volumeName, bucketName,
+ BucketArgs.newBuilder().setAcls(getAclList()).build());
Review comment:
This will cause creator acls added twice into the final list because the
same list will be added again when the passin bucketArgs has a non-empty acl
list.
{code}
List<OzoneAcl> listOfAcls = getAclList();
//ACLs from BucketArgs
if(bucketArgs.getAcls() != null) {
listOfAcls.addAll(bucketArgs.getAcls());
}
{code}
The list of acls are not merged properly when using List#addAll, which will
be fixed in HDDS-1927.
Let's file a separate JIRA for RpcClient#createBucket issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
