xiaoyuyao commented on a change in pull request #1257: HDDS-1913. Fix
OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312675211
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketSetPropertyRequest.java
##########
@@ -134,17 +132,6 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
bucketInfoBuilder.addAllMetadata(KeyValueUtil
.getFromProtobuf(bucketArgs.getMetadataList()));
- //Check ACLs to update
- if (omBucketArgs.getAddAcls() != null ||
- omBucketArgs.getRemoveAcls() != null) {
- bucketInfoBuilder.setAcls(getUpdatedAclList(oldBucketInfo.getAcls(),
- omBucketArgs.getRemoveAcls(), omBucketArgs.getAddAcls()));
- LOG.debug("Updating ACLs for bucket: {} in volume: {}",
- bucketName, volumeName);
- } else {
- bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
Review comment:
We have a similar problem here because OMBucketArgs does not have acls, we
will need to rely on the oldBucketInfo.getAcls to avoid reset existing acl on
bucket.
bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
