sodonnel commented on a change in pull request #1344: HDDS-1982 Extend
SCMNodeManager to support decommission and maintenance states
URL: https://github.com/apache/hadoop/pull/1344#discussion_r321204004
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -185,7 +190,7 @@ public int getNodeCount(NodeState nodestate) {
@Override
public NodeState getNodeState(DatanodeDetails datanodeDetails) {
Review comment:
Yes, the 'external interface' of SCMNodeManager will need to change but I
want to get these changes to be good internally before we push them up the
stack.
Thanks for taking the time to review this WIP. Glad to hear this is going in
the correct direction so I will look to tidy things up and then we can consider
the next step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
