sodonnel commented on a change in pull request #1344: HDDS-1982 Extend
SCMNodeManager to support decommission and maintenance states
URL: https://github.com/apache/hadoop/pull/1344#discussion_r323370846
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -417,9 +451,12 @@ private SCMNodeStat getNodeStatInternal(DatanodeDetails
datanodeDetails) {
@Override
public Map<String, Integer> getNodeCount() {
+ // TODO - This does not consider decom, maint etc.
Map<String, Integer> nodeCountMap = new HashMap<String, Integer>();
Review comment:
The existing code had Map<String, Integer>, but I agree it would be better
with <NodeState, Integer> or <NodeStatus, Integer>. I plan to leave this as is
for now, as this method is used only for JMX right now, and I plan to split
that out into a separate change via HDDS-2113 as there are some open questions
there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
