smengcl commented on a change in pull request #1360: HDDS-2007. Make ozone fs
shell command work with OM HA service ids
URL: https://github.com/apache/hadoop/pull/1360#discussion_r321917093
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java
##########
@@ -214,6 +216,11 @@ public
OzoneManagerProtocolClientSideTranslatorPB(OzoneConfiguration conf,
this.clientID = clientId;
}
+ public OzoneManagerProtocolClientSideTranslatorPB(OzoneConfiguration conf,
Review comment:
@bharatviswa504 It turns out there is one caller here:
https://github.com/apache/hadoop/blob/d69a1a0aa49614c084fa4b9546aceeeee65aebe4/hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/ReconControllerModule.java#L102
But we can easily change it to use the new constructor. Shall we do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
