smengcl commented on a change in pull request #1360: HDDS-2007. Make ozone fs 
shell command work with OM HA service ids 
URL: https://github.com/apache/hadoop/pull/1360#discussion_r322091772
 
 

 ##########
 File path: 
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
 ##########
 @@ -131,6 +142,13 @@ public void initialize(URI name, Configuration conf) 
throws IOException {
         // If port number is not specified, read it from config
         omPort = OmUtils.getOmRpcPort(conf);
       }
+    } else if (OmUtils.isServiceIdsDefined(conf)) {
 
 Review comment:
   I wonder when would `conf` not be an `OzoneConfiguration`? I tested that in 
all my test cases, `conf` is always `OzoneConfiguration`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to