bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make
ozone fs shell command work with OM HA service ids
URL: https://github.com/apache/hadoop/pull/1360#discussion_r321925879
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -137,12 +137,22 @@
private Text dtService;
private final boolean topologyAwareReadEnabled;
+ /**
+ * Creates RpcClient instance with the given configuration.
+ * @param conf Configuration
+ * @throws IOException
+ */
+ public RpcClient(Configuration conf) throws IOException {
Review comment:
My comment is for add to a notion of @VisibleForTesting, and I think this
can also be removed, as it is used only for testing. And it can be completely
removed, and use the new constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
