bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make 
ozone fs shell command work with OM HA service ids  
URL: https://github.com/apache/hadoop/pull/1360#discussion_r322930998
 
 

 ##########
 File path: 
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
 ##########
 @@ -131,6 +142,13 @@ public void initialize(URI name, Configuration conf) 
throws IOException {
         // If port number is not specified, read it from config
         omPort = OmUtils.getOmRpcPort(conf);
       }
+    } else if (OmUtils.isServiceIdsDefined(conf)) {
 
 Review comment:
   
https://github.com/apache/hadoop/blob/trunk/hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java#L154
 
   This is code line calling creation of BasicOzoneClientAdapterImpl. And below 
is the code where it checks if conf passed is instance of OzoneConfiguration or 
not, if not convert to OzoneConfiguration object.
   
   
https://github.com/apache/hadoop/blob/trunk/hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java#L112
   
   
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to