steveloughran commented on issue #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404#issuecomment-529899434 * I did a detailed review on this through vs.code but it managed to lose them all, which is a pain. I'll go through the code again and add the key technical ones * I can't get yetus to test this, as it doesn't trust you. If you attach the .patch to the HADOOP JIRA I can have a go at forcing jenkins to run it. We need yetus happy. * Yetus will be failing on line length; except when its only a few chars past the 80 mark, please chop down the new 90+ char lines * and where there are new params, new javadocs I also need to know what happens when a file is truncated. Before it would probably just finish and be happy one read() returned -1. Now it can differentiate between read-all-data and read-less-data. This is good-and we need to take advantage of it by failing when this happens (at the very least, reporting it).Can you add a test which uses truncate() to force this I have very high expectations on tests, the key one being "if a test fails on jenkins and all you have is the report -is that enough to debug a failure?". The new tests don't meet that requirement yet, which I'll highlight
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
