steveloughran commented on issue #1404: HDFS-13660 Copy file till the source 
file length during distcp
URL: https://github.com/apache/hadoop/pull/1404#issuecomment-530420060
 
 
   > With this new patch it fails with blocks not found exception as we are 
forcing it to read till a particular length. Do you want to write a testcase 
for this case ?
   
   yes. It's a change in behaviour, but probably a good one. A test will verify 
that things fail the way we expect -and will continue to do so.
   
   One little concern though: where does that filestatus come from? It's 
created in the mapper just before the operation, right? As if it's created when 
the list of files to copy is created (which I doubt...) then the current code 
handles the case where the file is changed between job schedule and task 
execution -that would be a visible regression, which we would have to worry 
about.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to