saintstack commented on a change in pull request #1432: HADOOP-16557.
[pb-upgrade] Upgrade protobuf.version to 3.7.1
URL: https://github.com/apache/hadoop/pull/1432#discussion_r325276884
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/BlockListAsLongs.java
##########
@@ -276,12 +276,12 @@ public void add(Replica replica) {
try {
// zig-zag to reduce size of legacy blocks
cos.writeSInt64NoTag(replica.getBlockId());
- cos.writeRawVarint64(replica.getBytesOnDisk());
- cos.writeRawVarint64(replica.getGenerationStamp());
+ cos.writeUInt64NoTag(replica.getBytesOnDisk());
+ cos.writeUInt64NoTag(replica.getGenerationStamp());
ReplicaState state = replica.getState();
// although state is not a 64-bit value, using a long varint to
// allow for future use of the upper bits
- cos.writeRawVarint64(state.getValue());
+ cos.writeUInt64NoTag(state.getValue());
Review comment:
Incompat change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
