saintstack commented on a change in pull request #1432: HADOOP-16557.
[pb-upgrade] Upgrade protobuf.version to 3.7.1
URL: https://github.com/apache/hadoop/pull/1432#discussion_r325276424
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcWritable.java
##########
@@ -106,7 +106,7 @@ Message getMessage() {
@Override
void writeTo(ResponseBuffer out) throws IOException {
int length = message.getSerializedSize();
- length += CodedOutputStream.computeRawVarint32Size(length);
+ length += CodedOutputStream.computeUInt32SizeNoTag(length);
Review comment:
Change from varint to 32bit? This breaks compatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
