Apache9 commented on a change in pull request #1496: HADOOP-16560. [YARN +
MAPREDUCE] use protobuf-maven-plugin to generat…
URL: https://github.com/apache/hadoop/pull/1496#discussion_r326931072
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml
##########
@@ -150,12 +150,12 @@
<artifactId>protobuf-maven-plugin</artifactId>
<version>${protobuf-maven-plugin.version}</version>
<configuration>
-
<protocArtifact>com.google.protobuf:protoc:3.6.1:exe:${os.detected.classifier}</protocArtifact>
<pluginId>grpc-java</pluginId>
<pluginArtifact>io.grpc:protoc-gen-grpc-java:1.15.1:exe:${os.detected.classifier}</pluginArtifact>
</configuration>
<executions>
<execution>
+ <id>src-compile-protoc</id>
Review comment:
I think we'd better align this. Otherwise it will be confusing to
developpers, as we define the plugin in the parent pom and reference it here,
but then we just skip all the exections from the parent pom and define a new
compile execution.
Anyway, we can keep it as is in this patch, and file a follow-on issue to
address it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
