Apache9 commented on a change in pull request #1496: HADOOP-16560. [YARN +
MAPREDUCE] use protobuf-maven-plugin to generat…
URL: https://github.com/apache/hadoop/pull/1496#discussion_r326955164
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
##########
@@ -118,45 +118,21 @@
</resources>
<plugins>
<plugin>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-maven-plugins</artifactId>
- <executions>
+ <groupId>org.xolstice.maven.plugins</groupId>
+ <artifactId>protobuf-maven-plugin</artifactId>
+ <executions>
<execution>
- <id>compile-protoc</id>
- <goals>
- <goal>protoc</goal>
- </goals>
+ <id>src-compile-protoc</id>
<configuration>
- <protocVersion>${protobuf.version}</protocVersion>
- <protocCommand>${protoc.path}</protocCommand>
- <imports>
-
<param>${basedir}/../../../hadoop-common-project/hadoop-common/src/main/proto</param>
- <param>${basedir}/src/main/proto</param>
- <param>${basedir}/src/main/proto/server</param>
- </imports>
- <source>
- <directory>${basedir}/src/main/proto</directory>
- <includes>
- <include>yarn_protos.proto</include>
- <include>yarn_service_protos.proto</include>
- <include>applicationmaster_protocol.proto</include>
- <include>applicationclient_protocol.proto</include>
- <include>containermanagement_protocol.proto</include>
-
<include>server/yarn_server_resourcemanager_service_protos.proto</include>
-
<include>server/resourcemanager_administration_protocol.proto</include>
- <include>application_history_client.proto</include>
- <include>server/application_history_server.proto</include>
- <include>client_SCM_protocol.proto</include>
- <include>server/SCM_Admin_protocol.proto</include>
- <include>yarn_csi_adaptor.proto</include>
- <include>YarnCsiAdaptor.proto</include>
- </includes>
- </source>
+ <additionalProtoPathElements>
+ <additionalProtoPathElement>
+
${basedir}/../../../hadoop-common-project/hadoop-common/src/main/proto
Review comment:
I mean it will compile the proto files under the server directory as we set
the protoc path to ${basedir}/src/main/proto, which is the parent directory of
${basedir}/src/main/proto/server, so we do not need to add extra
'additionalProtoPathElement' any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
