adoroszlai commented on a change in pull request #1488: HDDS-2159. Fix Race
condition in ProfileServlet#pid.
URL: https://github.com/apache/hadoop/pull/1488#discussion_r327103850
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/ProfileServlet.java
##########
@@ -208,11 +208,11 @@ protected void doGet(final HttpServletRequest req,
return;
}
// if pid is explicitly specified, use it else default to current process
- pid = getInteger(req, "pid", pid);
+ Integer processId = getInteger(req, "pid", pid);
// if pid is not specified in query param and if current process pid
Review comment:
It is determined in `getPid()` call from constructor:
https://github.com/apache/hadoop/blob/aa664d72595ddfcb1a1bf082381bb222e59db354/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/ProfileServlet.java#L126-L128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
