steveloughran commented on issue #1481: HADOOP-16587: Made auth endpoints configurable for MSI and refresh token flows URL: https://github.com/apache/hadoop/pull/1481#issuecomment-534093734 The overall patch looks good. I do worry that `AzureADAuthenticator.getTokenFromMsi()` also needs its `authority` value to be changeable from `"https://login.microsoftonline.com/"; + tenantGuid;`. Is just a guess: I don't know enough about the auth process as it applies to locations such as China. And of course I can't check. Bibin -is there a way for someone to verify that this patch Will let people authenticate in China if they configure it appropriately?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
