adoroszlai commented on a change in pull request #1513: HDDS-2149. Replace
FindBugs with SpotBugs
URL: https://github.com/apache/hadoop/pull/1513#discussion_r328660397
##########
File path: hadoop-ozone/dev-support/checks/findbugs.sh
##########
@@ -16,16 +16,22 @@
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
-mvn -B compile -fn findbugs:check -Dfindbugs.failOnError=false -f
pom.ozone.xml
+if ! type unionBugs >/dev/null 2>&1 || ! type convertXmlToText >/dev/null
2>&1; then
+ mvn -B -fae compile spotbugs:check -f pom.ozone.xml
Review comment:
Exactly, but I wanted to avoid reindenting the whole remaining script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
