sidseth commented on a change in pull request #1115: HADOOP-16207 testMR
failures
URL: https://github.com/apache/hadoop/pull/1115#discussion_r330160506
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/terasort/ITestTerasortOnS3A.java
##########
@@ -92,13 +118,27 @@ public boolean useInconsistentClient() {
return false;
}
+ @Override
+ protected String committerName() {
+ return committerName;
+ }
+
@Override
public void setup() throws Exception {
super.setup();
requireScaleTestsEnabled();
prepareToTerasort();
Review comment:
In prepareToTerasort - the config is modified via getYarn().getConfig.set()
...
This is going to change the config for every test that makes use of this
cluster. Likely better to create a new Configuration instance for the Job being
submitted, and setting these config parameters at the job level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
