sidseth commented on a change in pull request #1115: HADOOP-16207 testMR
failures
URL: https://github.com/apache/hadoop/pull/1115#discussion_r330702914
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/AbstractYarnClusterITest.java
##########
@@ -61,45 +69,70 @@
* If two subclasses of this class are instantiated in the same JVM, in order,
* they are guaranteed to be isolated.
*
- * History: this is a superclass extracted from
- * {@link AbstractITCommitMRJob} while adding support for testing terasorting.
- *
*/
public abstract class AbstractYarnClusterITest extends AbstractCommitITest {
private static final Logger LOG =
LoggerFactory.getLogger(AbstractYarnClusterITest.class);
- private static final int TEST_FILE_COUNT = 2;
- private static final int SCALE_TEST_FILE_COUNT = 50;
+ private static final int TEST_FILE_COUNT = 1;
+ private static final int SCALE_TEST_FILE_COUNT = 2;
- public static final int SCALE_TEST_KEYS = 1000;
+ public static final int SCALE_TEST_KEYS = 100;
public static final int BASE_TEST_KEYS = 10;
private boolean scaleTest;
- private boolean uniqueFilenames = false;
+ /**
+ * The static cluster binding with the lifecycle of this test; served
+ * through instance-level methods for sharing across methods in the
+ * suite.
+ */
+ @SuppressWarnings("StaticNonFinalField")
+ private static ClusterBinding clusterBinding;
Review comment:
I think I understand the concern I raised a little better now.
Will the two derived tests ever run in parallel on the same VM?
- If so, there's a problem with the static cluster being in the base class -
since the cluster will be shared and shutdown when either of the tests complete.
If parallel tests will only use separate VMs - we should be OK.
If a single VM is used to run the tests serially - the "clusterBinding=null"
is an important change, which I think you've already made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
