steveloughran commented on a change in pull request #1664: HADOOP-16658 - S3A
connector does not support including the token ren…
URL: https://github.com/apache/hadoop/pull/1664#discussion_r337636061
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -3186,7 +3187,8 @@ public String getCanonicalServiceName() {
entryPoint(Statistic.INVOCATION_GET_DELEGATION_TOKEN);
LOG.debug("Delegation token requested");
if (delegationTokens.isPresent()) {
- return delegationTokens.get().getBoundOrNewDT(encryptionSecrets);
+ return delegationTokens.get().getBoundOrNewDT(encryptionSecrets,
+ (renewer!=null ? new Text(renewer) : null));
Review comment:
* need to make sure that null results in renewer == new Text()
* add some spaces round the `!=`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
