steveloughran commented on a change in pull request #1664: HADOOP-16658 - S3A
connector does not support including the token ren…
URL: https://github.com/apache/hadoop/pull/1664#discussion_r337636779
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/AbstractS3ATokenIdentifier.java
##########
@@ -103,17 +103,19 @@
* Constructor.
* @param kind token kind.
* @param uri filesystem URI.
- * @param owner token owner
+ * @param owner token owner.
+ * @param renewer token renewer.
* @param origin origin text for diagnostics.
* @param encryptionSecrets encryption secrets to set.
*/
protected AbstractS3ATokenIdentifier(
final Text kind,
final URI uri,
final Text owner,
+ final Text renewer,
final String origin,
final EncryptionSecrets encryptionSecrets) {
- this(kind, owner, new Text(), new Text(), uri);
+ this(kind, owner, renewer, new Text(), uri);
Review comment:
the renewer may now be null. should we add a `new Text()` if a null comes in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
