steveloughran commented on issue #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#issuecomment-545988988 ## Production code This is making code fairly verbose. I think you can do more here. * add some private methods to invoke the latency tracker * Maybe use try-with-resources to managed the life of a specific operation, as we do with DurationInfo * it be good to have some documentation including a reference to the "ABFS API logging service" Without the documentation, features like this only get used by the few people that know about them. And more insidiously, the only get maintained by people that care about. Which of course they don't do unless they or somebody they know is using the feature. It is in your interests to make sure we all do use it. And if we can use it to debug things, very very useful. ## Tests I worry that this is going to be very very brittle towards latency, overloaded machines, network settings, etc. There's already an azure test which is pretty unreliable for this reason (ITestAzureFileSystemInstrumentation). I don't want to this to have the same problems. Have you run any tests against the long haul store, or using parallel test runs to slow down the test?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
