steveloughran commented on issue #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#issuecomment-548487181 LGTM; the move to try-with-resources makes for much cleaner code. It's clearly an ugly retrofit of some attempt of an object lifecycle on java, but, well, it works fine provided those objects don't throw exceptions doing close() calls. I'll defer to Da Zhou on actually azure binding/networking issues. > I have also added some details on the ABFS logs, particularly how the logs look, how to enable and obtain them. thanks! > Would you also want me to elaborate on the handling of these logs by the Azure's internal subsystems? You've done enough. I'm just trying to make sure there's enough here for anyone to get out and play with. If it can only be done with access to Azure internals -so be it... It's still good for people to understand what can be collected and how, so that future operations are instrumented. > The tests here have no network IO -- all they are testing is correctness and performance of an isolated unit that uses a ConcurrentQueue at its core. Would you still consider them very very brittle? Passing of these tests also ensures that the addition of the tracking code doesn't add much cost to the existing ABFS code. Let's see what happens. I've had lots of problems in the past with code which inserts that a set of operations must complete within a certain time period -as under load on parallel runs these can start to fail. If it does happen, the time limits may need changing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
