[
https://issues.apache.org/jira/browse/HADOOP-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967997#comment-16967997
]
David Mollitor edited comment on HADOOP-16686 at 11/6/19 1:18 AM:
------------------------------------------------------------------
Including new patch that fixes unit test.
Unit test was testing for specific values returned from the {{compare()}}
method, even though the only guarantees is that the method will return a
negative integer, zero, or a positive integer. One of the changes changed the
value returned, but it was still the correct sign.
https://docs.oracle.com/javase/8/docs/api/java/lang/Comparable.html#compareTo-T-
was (Author: belugabehr):
Including new patch that fixes unit test.
Unit test was testing for specific values returned from the {{compare()}}
method, even though the only guarantees is that the method will return a
negative integer, zero, or a positive integer.
https://docs.oracle.com/javase/8/docs/api/java/lang/Comparable.html#compareTo-T-
> Review Writable Classes
> -----------------------
>
> Key: HADOOP-16686
> URL: https://issues.apache.org/jira/browse/HADOOP-16686
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 3.2
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HADOOP-16686.1.patch, HADOOP-16686.2.patch
>
>
> Based on my work in HADOOP-16678, I figured I'd look at some of the other
> {{Writeable}} classes. I wanted these looking good because they are so
> core/base to the Hadoop framework.
> Formatted the classes to remove checkstyle violations, and spiffed things up
> where I saw fit. This includes improving some {{equals}} and {{hashcode}}
> implementation. For example:
>
> [https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/LongWritable.java#L66]
>
> [https://stackoverflow.com/questions/4045063/how-should-i-map-long-to-int-in-hashcode]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
