[
https://issues.apache.org/jira/browse/HADOOP-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969423#comment-16969423
]
David Mollitor edited comment on HADOOP-16686 at 11/7/19 5:25 PM:
------------------------------------------------------------------
[~elgoiri] Maybe the 'HiddenField' check should be modified to allow the
current syntax. It is very common in setters to use the current format.
[https://stackoverflow.com/questions/7776046/checkstyle-how-to-resolve-hidden-field-error]
I'll address the other ones.
Edit: The Hadoop checkstyle configuration is already configured in this way.
I'll have to figure out why it's hitting here.
was (Author: belugabehr):
[~elgoiri] Maybe the 'HiddenField' check should be modified to allow the
current syntax. It is very common in setters to use the current format.
[https://stackoverflow.com/questions/7776046/checkstyle-how-to-resolve-hidden-field-error]
I'll address the other ones.
> Review Writable Classes
> -----------------------
>
> Key: HADOOP-16686
> URL: https://issues.apache.org/jira/browse/HADOOP-16686
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 3.2
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HADOOP-16686.1.patch, HADOOP-16686.2.patch,
> HADOOP-16686.3.patch
>
>
> Based on my work in HADOOP-16678, I figured I'd look at some of the other
> {{Writeable}} classes. I wanted these looking good because they are so
> core/base to the Hadoop framework.
> Formatted the classes to remove checkstyle violations, and spiffed things up
> where I saw fit. This includes improving some {{equals}} and {{hashcode}}
> implementation. For example:
>
> [https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/LongWritable.java#L66]
>
> [https://stackoverflow.com/questions/4045063/how-should-i-map-long-to-int-in-hashcode]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
