belugabehr commented on a change in pull request #1716: HADOOP-16691: Unify
Logging in UserGroupInformation
URL: https://github.com/apache/hadoop/pull/1716#discussion_r345971167
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
##########
@@ -1033,18 +1012,18 @@ public void run() {
try {
tgtEndTime = tgt.getEndTime().getTime();
} catch (NullPointerException npe) {
- LOG.error(String.format("NPE thrown while getting " +
- "KerberosTicket endTime. Aborting renew thread for %s.",
- getUserName()), ie);
+ LOG.error("NPE thrown while getting KerberosTicket endTime. "
+ + "Aborting renew thread for {}.", getUserName(), ie);
return;
}
- LOG.warn(String.format("Exception encountered while running the " +
- "renewal command for %s. " +
- "(TGT end time:%d, renewalFailures: %d, " +
- "renewalFailuresTotal: %d)", getUserName(), tgtEndTime,
- metrics.renewalFailures.value(),
- metrics.renewalFailuresTotal.value()), ie);
+ LOG.warn(
+ "Exception encountered while running the "
+ + "renewal command for %s. "
Review comment:
Great catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
