belugabehr commented on a change in pull request #1716: HADOOP-16691: Unify
Logging in UserGroupInformation
URL: https://github.com/apache/hadoop/pull/1716#discussion_r345972073
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
##########
@@ -1911,14 +1882,6 @@ protected Subject getSubject() {
}
}
- private void logPrivilegedAction(Subject subject, Object action) {
- if (LOG.isDebugEnabled()) {
- // would be nice if action included a descriptive toString()
- String where = new Throwable().getStackTrace()[2].toString();
Review comment:
This hardly seems like it should merit its own method. It's trivial to do
in-line and it seems like a bad pattern to have... every class that wants this
functionality would need its own copy of this routine. I don't think we want
that. It would be better in a utility class, that everyone can share, but I
think that is overkill.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
