bgaborg commented on a change in pull request #1691: HADOOP-16424. S3Guard
fsck: Check internal consistency of the MetadataStore
URL: https://github.com/apache/hadoop/pull/1691#discussion_r350193948
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3GuardFsckViolationHandler.java
##########
@@ -343,4 +343,34 @@ public String getError() {
return "The entry for the path is tombstoned in the MS.";
}
}
+
+ /**
+ * The violation handler there's no parent in the MetadataStore.
+ */
+ public static class OrphanDDBEntry extends ViolationHandler {
+
+ public OrphanDDBEntry(S3GuardFsck.ComparePair comparePair) {
+ super(comparePair);
+ }
+
+ @Override
+ public String getError() {
+ return "The DDB entry is orphan - there is no parent in the MS.";
+ }
+ }
+
+ /**
+ * The violation handler when there's no last updated field for the entry.
+ */
+ public static class NoLastUpdatedField extends ViolationHandler {
+
+ public NoLastUpdatedField(S3GuardFsck.ComparePair comparePair) {
+ super(comparePair);
+ }
+
+ @Override
+ public String getError() {
+ return "";
Review comment:
good catch. fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
