bgaborg commented on a change in pull request #1691: HADOOP-16424. S3Guard
fsck: Check internal consistency of the MetadataStore
URL: https://github.com/apache/hadoop/pull/1691#discussion_r350218322
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3GuardTool.java
##########
@@ -1607,6 +1610,7 @@ public int run(String[] args, PrintStream out) throws
}
final CommandFormat commandFormat = getCommandFormat();
+
Review comment:
yes. and here's why: let the user define the order in which he wants to run
the checks.
I was thinking about the ordering of checks a bit, and the following seemed
appropriate:
1. s3->ddb
2. ddb->s3
3. internal ddb
Reason: the first 2 can change the internal structure of the ddb but after
the third one we can be sure that the store is left in a consistent state.
But it's just a recommendation. Let's make the call exclusive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
