[
https://issues.apache.org/jira/browse/HADOOP-7573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095003#comment-13095003
]
Todd Lipcon commented on HADOOP-7573:
-------------------------------------
I agree that this should be at TRACE level. You'd probably want to add
something to the log4j.properties to comment out.
Specific patch problems:
- should be ".options_read" - otherwise we get Configurationoptions_read as the
logger category
- The HashSet is unsynchronized - multiple writers to an unsynchronized hashset
can cause runtime exceptions or infinite loops
- why are you importing NetUtils?
- extra indentation in the javadoc text
> hadoop should log configuration reads
> -------------------------------------
>
> Key: HADOOP-7573
> URL: https://issues.apache.org/jira/browse/HADOOP-7573
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.20.203.0
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Priority: Minor
> Fix For: 0.20.206.0
>
> Attachments: HADOOP-7573.patch, HADOOP-7573.patch, HADOOP-7573.patch
>
>
> For debugging, it would often be valuable to know which configuration options
> ever got read out of the Configuration into the rest of the program -- an
> unread option didn't cause a problem. This patch logs the first time each
> option is read.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
