[
https://issues.apache.org/jira/browse/HADOOP-7573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104389#comment-13104389
]
Steve Loughran commented on HADOOP-7573:
----------------------------------------
I like the idea, but not this initial implementation
# sychronising everything adds a bottleneck. You could do a check for presence
outside the synchronized block and then do the synchronized add/trace iff that
first {contains()} operation fails.
# having a static method stops subclasses doing useful stuff. I think I'm the
only person to have done the subclassing other than the ubuquitous JobConf.
What that subclassing would do would let you write the tests that this current
patch lacks.
# what is your test plan
# the condition for logging is the {{isInfoEnabled()}} but then log.trace() is
called; the test should be downgraded to isTraceEnabled().
# the optsRead hash set ought to be final, as should OPT_READ_LOG.
# This would be a 0.23+ feature.
If you can send us a draft of the paper to show the value, then we could look
at it some more -I think it could be useful
> hadoop should log configuration reads
> -------------------------------------
>
> Key: HADOOP-7573
> URL: https://issues.apache.org/jira/browse/HADOOP-7573
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.20.203.0
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Priority: Minor
> Fix For: 0.20.206.0
>
> Attachments: HADOOP-7573.patch, HADOOP-7573.patch, HADOOP-7573.patch,
> HADOOP-7573.patch
>
>
> For debugging, it would often be valuable to know which configuration options
> ever got read out of the Configuration into the rest of the program -- an
> unread option didn't cause a problem. This patch logs the first time each
> option is read.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
