bgaborg commented on a change in pull request #1707: HADOOP-16697. Tune/audit
auth mode
URL: https://github.com/apache/hadoop/pull/1707#discussion_r351812756
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java
##########
@@ -898,23 +934,44 @@ DirListingMetadata
getDirListingMetadataFromDirMetaAndList(Path path,
path, entry);
}
}
- ancestry.put(path, entry);
+ // add the entry to the ancestry map as a requested value.
+ ancestry.put(path, Pair.of(EntryOrigin.Requested, entry));
Path parent = path.getParent();
while (!parent.isRoot() && !ancestry.containsKey(parent)) {
if (!ancestorState.findEntry(parent, true)) {
- // don't add this entry, but carry on with the parents
- LOG.debug("auto-create ancestor path {} for child path {}",
Review comment:
this is where we lost authoritative listing for parents. we talked about
this. nice catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
