bgaborg commented on a change in pull request #1707: HADOOP-16697. Tune/audit
auth mode
URL: https://github.com/apache/hadoop/pull/1707#discussion_r351803754
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java
##########
@@ -748,7 +757,22 @@ private DDBPathMetadata innerGet(Path path, boolean
wantEmptyDirectoryFlag)
boolean hasChildren = readOp.retry("get/hasChildren",
path.toString(),
true,
- () -> table.query(spec).iterator().hasNext());
+ () -> {
+ // issue the query
+ final IteratorSupport<Item, QueryOutcome> it = table.query(
+ spec).iterator();
+ // if non empty, log the result to aid with some debugging
+ if (it.hasNext()) {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Dir {} is non-empty", status.getPath());
+ while(it.hasNext()) {
+ LOG.debug("{}", itemToPathMetadata(it.next(), username));
Review comment:
On debug we will log a lot here, but it looks like that's the goal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
