[ 
https://issues.apache.org/jira/browse/HADOOP-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095552#comment-13095552
 ] 

Robert Joseph Evans commented on HADOOP-7598:
---------------------------------------------

That is true, and I think a more common use case then someone deleting -- or 
adding ++ to a file.

With patch dry-run we would still have to try it at several different levels 
because it will not output patching file if the patch did not apply correctly.

> smart-apply-patch.sh does not handle patching from a sub directory correctly.
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-7598
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7598
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7598-v1.patch, HADOOP-7598-v2.patch, 
> HADOOP-7598-v3.patch
>
>
> smart-apply-patch.sh does not apply valid patches from trunk, or from git 
> like it was designed to do in some situations.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to