[
https://issues.apache.org/jira/browse/HADOOP-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098028#comment-13098028
]
Robert Joseph Evans commented on HADOOP-7598:
---------------------------------------------
Like I said in the previous comments I made the change because I deleted an XML
comment {code}-->{code} as part of MAPREDUCE-2864 Which turned into a diff line
{code}--->{code} which messed up the grep statements to find which files
changed, so it was not detecting the proper level to apply the patch. This is
rare enough that it is not a big deal, but it was so painful to work around (I
made 4 separate patches trying to find out what happened, because each of them
applied just fine at the root level) that I decided to make a fix for it
anyways.
> smart-apply-patch.sh does not handle patching from a sub directory correctly.
> -----------------------------------------------------------------------------
>
> Key: HADOOP-7598
> URL: https://issues.apache.org/jira/browse/HADOOP-7598
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Fix For: 0.23.0, 0.24.0
>
> Attachments: HADOOP-7598-v1.patch, HADOOP-7598-v2.patch,
> HADOOP-7598-v3.patch, HADOOP-7598-v4.patch
>
>
> smart-apply-patch.sh does not apply valid patches from trunk, or from git
> like it was designed to do in some situations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
