[ 
https://issues.apache.org/jira/browse/HADOOP-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096358#comment-13096358
 ] 

Hadoop QA commented on HADOOP-7507:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12492679/HADOOP-7507v6.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed these unit tests:

                  org.apache.hadoop.io.serializer.avro.TestAvroSerialization
                  org.apache.hadoop.io.TestText
                  org.apache.hadoop.conf.TestConfiguration
                  org.apache.hadoop.io.TestEnumSetWritable
                  org.apache.hadoop.fs.TestPath
                  org.apache.hadoop.ipc.TestAvroRpc

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/127//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/127//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/127//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/127//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/127//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/127//console

This message is automatically generated.

> jvm metrics all use the same namespace
> --------------------------------------
>
>                 Key: HADOOP-7507
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7507
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.20.2
>            Reporter: Jeff Bean
>            Assignee: Alejandro Abdelnur
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7507-v2.patch, HADOOP-7507v1.patch, 
> HADOOP-7507v3.patch, HADOOP-7507v4.patch, HADOOP-7507v5.patch, 
> HADOOP-7507v6.patch, JvmMetrics.java, hadoop-metrics.properties, 
> screenshot-1.jpg
>
>
> Ganglia jvm metrics don't make sense because it's not clear which java 
> process the metrics refer to. In fact, all hadoop java processes running on a 
> node report their jvm metrics to the same namespace.
> The metrics are exposed by the "jvm" context in JvmMetrics.java. This leads 
> to confusing and nonsensical graphs in ganglia and maybe other monitoring 
> tools.
> One way to fix this is to make sure the process name is reported in the jvm 
> context, making it clear which process is associated with the context, and 
> separating out the jvm metrics per process.
> This is marked as an "incompatible change" because the fix provided removes 
> the JVM metrics and replaces it with process-specific metrics.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to