[ 
https://issues.apache.org/jira/browse/HADOOP-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099229#comment-13099229
 ] 

Todd Lipcon commented on HADOOP-7507:
-------------------------------------

- In hadoop-metrics2.properties, we should probably default 
tagsForPrefix.jvm=ProcessName, right? So that the default behavior with the new 
metrics system solves the original issue of this JIRA
- TAGS_FOR_PREFIX_PROPERTY can be private
- minor efficiency nit: change createPrefix() to be appendPrefix(MetricsRecord 
record, StringBuilder builder) so you can just call appendPrefix(record, sb);
- createPrefix could be package-private, right?

> jvm metrics all use the same namespace
> --------------------------------------
>
>                 Key: HADOOP-7507
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7507
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.20.2
>            Reporter: Jeff Bean
>            Assignee: Alejandro Abdelnur
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7507-v2.patch, HADOOP-7507v1.patch, 
> HADOOP-7507v3.patch, HADOOP-7507v4.patch, HADOOP-7507v5.patch, 
> HADOOP-7507v6.patch, JvmMetrics.java, hadoop-metrics.properties, 
> screenshot-1.jpg
>
>
> Ganglia jvm metrics don't make sense because it's not clear which java 
> process the metrics refer to. In fact, all hadoop java processes running on a 
> node report their jvm metrics to the same namespace.
> The metrics are exposed by the "jvm" context in JvmMetrics.java. This leads 
> to confusing and nonsensical graphs in ganglia and maybe other monitoring 
> tools.
> One way to fix this is to make sure the process name is reported in the jvm 
> context, making it clear which process is associated with the context, and 
> separating out the jvm metrics per process.
> This is marked as an "incompatible change" because the fix provided removes 
> the JVM metrics and replaces it with process-specific metrics.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to