bgaborg commented on a change in pull request #1815: HADOOP-16801:
S3Guard-listFiles will not query s3 if all listings are…
URL: https://github.com/apache/hadoop/pull/1815#discussion_r371825485
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -1444,15 +1444,17 @@ public void deleteObjectAtPath(final Path path,
final Path path,
final S3AFileStatus status,
final boolean collectTombstones,
- final boolean includeSelf) throws IOException {
+ final boolean includeSelf,
+ final boolean rejectAuthoritative) throws IOException {
Review comment:
There's a call to this method in two places, and both of these places pass
`true` for rejectAuthoritative.
I don't see the point of modifying `OperationCallbacks` interface for this -
just pass true from this method instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
