mustafaiman commented on a change in pull request #1815: HADOOP-16801:
S3Guard-listFiles will not query s3 if all listings are…
URL: https://github.com/apache/hadoop/pull/1815#discussion_r372070883
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/OperationCallbacks.java
##########
@@ -119,7 +119,8 @@ void deleteObjectAtPath(Path path,
Path path,
S3AFileStatus status,
boolean collectTombstones,
- boolean includeSelf) throws IOException;
+ boolean includeSelf,
+ boolean rejectAuthoritative) throws IOException;
Review comment:
You are right. At first I introduced the extra parameter because I thought
some tools might use the improvement in this PR and other can continue to work
the same way by forcing non-authoritative. Given that only Import tool use this
method and it should force non-authoritative, implementers of this method
should force non-authoritative. The flag has no use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
