ThomasMarquardt commented on a change in pull request #1842: HADOOP-16730 :
ABFS: Add Authorizer Interface
URL: https://github.com/apache/hadoop/pull/1842#discussion_r384038589
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java
##########
@@ -266,16 +295,23 @@ public AbfsRestOperation createPath(final String path,
final boolean isFile, fin
return op;
}
- public AbfsRestOperation renamePath(final String source, final String
destination, final String continuation)
+ public AbfsRestOperation renamePath(String source, final String destination,
final String continuation)
throws AzureBlobFileSystemException {
final List<AbfsHttpHeader> requestHeaders = createDefaultHeaders();
- final String encodedRenameSource = urlEncode(FORWARD_SLASH +
this.getFileSystem() + source);
+ final AbfsUriQueryBuilder srcQueryBuilder = new AbfsUriQueryBuilder();
+ appendSASTokenToQuery(source, SASTokenProvider.RENAME_SOURCE_OPERATION,
srcQueryBuilder);
+ String sasToken = srcQueryBuilder.toString();
+
+ final String encodedRenameSource =
+ urlEncode(FORWARD_SLASH + this.getFileSystem() + source) + sasToken;
+ LOG.trace("Rename source queryparam added {}", encodedRenameSource);
Review comment:
We should only create the builder and append the sasToken when authType is
AuthType.SAS. I don't think we should create throw-away objects. The driver
should be lean and only allocate when necessary to reduce overall pressure on
GC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
